[Ffmpeg-devel] [PATCH] get rid of pgmyuv compat hack

[Baptiste Coudurier]

Michael Niedermayer wrote:
> Hi
> 
> On Sun, Nov 05, 2006 at 08:33:31PM +0100, Baptiste Coudurier wrote:
>> Michael Niedermayer wrote:
>>> Hi
>>>
>>> On Sat, Nov 04, 2006 at 09:40:09PM +0100, Baptiste Coudurier wrote:
>>>> Hi
>>>>
>>>> $subject
>>>>
>>>> that also updates regression tests for mpeg4-PSP test which were wrong
>>>> since it was not using -f pgmyuv.
>>> it breaks existing scripts
>>>
>>> there mere 10 lines of code less dont seem to justify that
>>>
>> Which ones ? Regression scripts are updated.
> 
> the ones end users wrote ...
> 

How can we bless removing or breaking any API ever ?

>> Removing hacks is always good, and IMHO it justifies it. We already
>> broke scripts when AVImageFormat was removed. Let's finish the work.
> 
> make useage of that hack print a warning which says its deprecated and
> explains what else the user should rather do 

Well since we have no release schedule, how much time will that stay in
the code ? If nobody care about that, nothing will be ever cleaned.

> and AVImageFormat was a lot of unneeded code, this here are just 10 lines
> imagine ls, rm or some other standard tool to drop "historic" command line
> options because they need 10 lines of code
> 

This hack was introduced when AVImageFormat was introduced (I checked
cvs log). It seems clear to me that it must go now that AVImageFormat is
gone.

We already removed or changed many command line options since we moved
ffmpeg.c to AVOptions. I really see no rationale not removing that hack
here, now.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312