[Ffmpeg-devel] [PATCH] get rid of CODEC_ID_MPEG4AAC after next major version bump

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Thu, Nov 09, 2006 at 12:23:10AM +0100, Baptiste Coudurier wrote:
> [...]
>> Index: libavformat/avidec.c
>> ===================================================================
>> --- libavformat/avidec.c	(revision 6947)
>> +++ libavformat/avidec.c	(working copy)
>> @@ -443,6 +443,8 @@
>>                      /* special case time: To support Xan DPCM, hardcode
>>                       * the format if Xxan is the video codec */
>>                      st->need_parsing = 1;
>> +                    if (st->codec->codec_id == CODEC_ID_AAC && st->codec->extradata_size)
>> +                        st->need_parsing = 0; /* do not parse since header is in extradata */
>
> why? what bad happens if st->need_parsing = 1 ?

The parser fails.

-- 
M?ns Rullg?rd
mru at inprovide.com