[Ffmpeg-devel] decode_init_vlc in h264.c

[Panagiotis Issaris]

Hi,

On Wed, 2006-11-08 at 18:49 +0100, Michael Niedermayer wrote:
> Hi
> 
> On Wed, Nov 08, 2006 at 04:07:50PM +0100, Panagiotis Issaris wrote:
> > Hi,
> > 
> > The function decode_init_vlc() takes a H264Context as a parameter
> > although it does not use it:
> > 
> > 3152 static void decode_init_vlc(H264Context *h){
> > ...
> > 3159         init_vlc(&chroma_dc_coeff_token_vlc,
> > CHROMA_DC_COEFF_TOKEN_VLC_BITS, 4*5,
> > 3160                  &chroma_dc_coeff_token_len [0], 1, 1,
> > 3161                  &chroma_dc_coeff_token_bits[0], 1, 1, 1);
> > 
> > ...
> > }
> > The only variables being accessed are static globals.
> > 
> > Should the h parameter go away?
> 
> if its unused, yes why not ...
OK to apply?

Regressions test succeed except for the ffserver part which fails in the
same way as it did before this patch.

With friendly regards,
Takis

-- 
vCard: http://www.issaris.org/pi.vcf
Public key: http://www.issaris.org/pi.key
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20061109T130650-ffmpeg-decode_init_vlc.diff
Type: text/x-patch
Size: 580 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061109/893d8095/attachment.bin>