[Ffmpeg-devel] Getting rid of inlining failure warnings

[Panagiotis Issaris]

Hi,

The attached patch gets rid of inlining failure warnings. It is _not_
meant for inclusion in SVN as it:
1. Removes the inline specifier inconsistently, meaning that I f.e.
removed the inline keyword for some versions of a function and not for
the other versions of it (e.g. #ifdef ...X64 or #ifdef ...X32).
2. Removes it from even really small functions.
3. Generates new warnings.

Total number of warnings before the patch: 1141
Total number of "inlining failed in call to ..." warnings before the
patch: 353
After this patch: 0
The new total number of warnings after this patch is not 1141-353, but
1077, as new warnings popped up as the inline specifier was removed. In
fact, there were a lot of "?emms? defined but not used", with "emms"
substituted by the function name I removed the inline specifier from.


There are some inline's which are failing which I do not understand:
* read_time: This one fails, although it is just a few lines long,
actually just using the RDTSC asm instruction. It actually shows:
"large-function-growth limit reached", so I'm guessing that the
encompassing function is inlining a lot of other functions causing it to
grow to much, and because of this growth, inlining even this small
function fails?
* emms_c: Exactly the same case for this one, I guess.

Any comments? 

I'll send a new patch later in which I will send smaller patches,
removing the inline specifier only if no new warnings are introduced by
doing so.

With friendly regards,
Takis

-- 
vCard: http://www.issaris.org/pi.vcf
Public key: http://www.issaris.org/pi.key
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20061109T141044-ffmpeg-inline.diff
Type: text/x-patch
Size: 19823 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061109/896f1eae/attachment.bin>