[Ffmpeg-devel] [PATCH] Getting rid of inlining failure warnings

[Guillaume Poirier]

Hi,

Panagiotis Issaris wrote:
> Hi,
> 
> On Thu, 2006-11-09 at 14:59 +0100, Panagiotis Issaris wrote:
> 
>>[...]
>>I'll send a new patch later in which I will send smaller patches,
>>removing the inline specifier only if no new warnings are introduced by
>>doing so.
> 
> 
> The attached patch gets rid of inlining failure warnings.


BTW, I'd like to underline that on C, "inline" keyword just affects
the compiler's inlining heuristic.
That means that if you add the "inline" keyword somewhere, you just
introduce a bias towards more inlining, but that's about it.
Likewise, if you don't put "inline" keyword before a function, that
doesn't mean the compiler won't inline it.

So if you really don't want to see the inlining failure warnings, the
only solution is to remove the -Winline option or to remove most
inline keywords.
Off course, none of these are satisfactory, maybe we should have a
--enable-console-spamming to configure script so that we print these
kind of warning only for ppl who care.

Just IMHO.

Yeah, that's obvious for most ppl. here on this list, but for the
minority of ppl who didn't know, a "repost" doesn't harm too much IMHO.

Guillaume