[Ffmpeg-devel] [PATCH] imc should use av_log2

Benjamin Larsson banan
Fri Nov 10 21:01:52 CET 2006


Reimar D?ffinger wrote:

>Hello,
>On Fri, Nov 10, 2006 at 08:46:53PM +0100, Benjamin Larsson wrote:
>  
>
>>>You only asked if it fixes the problem and not for review. But as an
>>>absolute minimum comments must be added that explain those constants.
>>>      
>>>
>>Well there where no comments in the original code.
>>    
>>
>
>Of course there are no comments to explain that
>log2(10) * 0.25
>is log2(10) * 0.25 since that's obvious.
>But it is less that obvious that
>0.8304... is log2(10) * 0.25.
>  
>

Ok, I will add that kind of info if I get ok on the patch.

>Greetings,
>Reimar D?ffinger
>  
>

MvH
Benjamin Larsson

-- 
new tiny signature





More information about the ffmpeg-devel mailing list