[Ffmpeg-devel] [PATCH] add some static keywords

[Benjamin Larsson]

M?ns Rullg?rd wrote:

>I did a search for extern symbols that were not actually used outside
>the file that defined them.  The most obvious ones I've already made
>static.  Here's a patch for the remainder.  It obviously builds on my
>machine.  However I'm not certain that some of these perhaps were
>intentionally extern.
>
>Please comment.
>
>  
>
>------------------------------------------------------------------------
>
>[...]
>Index: libavcodec/ac3.h
>===================================================================
>--- libavcodec/ac3.h	(revision 6974)
>+++ libavcodec/ac3.h	(working copy)
>@@ -57,9 +57,3 @@
> extern const uint16_t fgaintab[8];
> #endif
> 
>-void ac3_common_init(void);
>-void ac3_parametric_bit_allocation(AC3BitAllocParameters *s, uint8_t *bap,
>-                                   int8_t *exp, int start, int end,
>-                                   int snroffset, int fgain, int is_lfe,
>-                                   int deltbae,int deltnseg,
>-                                   uint8_t *deltoffst, uint8_t *deltlen, uint8_t *deltba);
>Index: libavcodec/ac3enc.c
>===================================================================
>--- libavcodec/ac3enc.c	(revision 6974)
>+++ libavcodec/ac3enc.c	(working copy)
>@@ -119,6 +119,7 @@
> 
> /* AC3 bit allocation. The algorithm is the one described in the AC3
>    spec. */
>+static
> void ac3_parametric_bit_allocation(AC3BitAllocParameters *s, uint8_t *bap,
>                                    int8_t *exp, int start, int end,
>                                    int snroffset, int fgain, int is_lfe,
>@@ -794,7 +795,7 @@
>     return 0;
> }
> 
>-void ac3_common_init(void)
>+static void ac3_common_init(void)
> {
>     int i, j, k, l, v;
>     /* compute bndtab and masktab from bandsz */
>  
>
>------------------------------------------------------------------------
>

Hold off the ac3 changes for a while, lets see what the SoC ac3 decoder
will bring.

MvH
Benjamin Larsson

-- 
new tiny signature