[Ffmpeg-devel] [PATCH] add some static keywords

Diego Biurrun diego
Sun Nov 12 04:09:10 CET 2006


On Sun, Nov 12, 2006 at 12:33:53AM +0100, Benjamin Larsson wrote:
> M?ns Rullg?rd wrote:
> 
> >I did a search for extern symbols that were not actually used outside
> >the file that defined them.  The most obvious ones I've already made
> >static.  Here's a patch for the remainder.  It obviously builds on my
> >machine.  However I'm not certain that some of these perhaps were
> >intentionally extern.
> >
> >Please comment.
> 
> Hold off the ac3 changes for a while, lets see what the SoC ac3 decoder
> will bring.

This is the wrong way around IMO.  If something comes out of the SoC we
can still undo the changes.  In the meantime there should be an
improvement.

Diego





More information about the ffmpeg-devel mailing list