[Ffmpeg-devel] [PATCH] MinGW interactive support

Víctor Paesa wzrlpy
Tue Nov 21 23:46:55 CET 2006


> Hi
>
> On Sat, Nov 11, 2006 at 04:06:58PM -0200, Ramiro Polla wrote:
>> Hello,
>>
>> V?ctor Paesa wrote:
>> >Hi,
>> >
>> >>Hello,
>> >>
>> >>Interactive support for MinGW is currently disabled, even though it
>> does
>> >>support the signal() function and can read non-blocking from the
>> console.
>> >>
>> >>It only works on Windows' command prompts, not on MSys, but that is a
>> bug
>> >>in MSys, which should support those features.
>> >>
>> >>Attached are two patches, which do the same thing (binary identical),
>> but
>> >>one has more #ifdefs than the other. It's up for the maintainers to
>> decide
>> >>which one is cleaner (special-casing each term_ function, or making
>> one
>> >>copy for MinGW and another for the rest, as is currently the case).
>> >>
>> >>But first, *before it's reviewed*, I ask for people to test it
>> (specially
>> >>people that use Windows and Cygwin).
>> >>
>> >>
>> >
>> >Under Cygwin both patches build OK, ctrl-c and read non-blocking
>> >work OK too.
>> >
>> >
>>
>> New patches to be reviewed by maintainers. Again in two flavours, so
>> that you decide which one is cleaner.
>
> [...]
>> @@ -289,13 +291,15 @@
>>  } AVInputFile;
>>
>>  #ifndef __MINGW32__
>> -
>>  /* init terminal so that we can grab keys */
>
> cosmetic
>
> the patch is probably ok otherwise
>
> the other patch mixes cosmetics (moving functions around) with functional
> changes ...
>

Sorry for the delay, under Cygwin ffmpeg.c.4.patch and ffmpeg.c.5.patch
both build OK, ctrl-c and read non-blocking work OK too.

Regards,
V?ctor




More information about the ffmpeg-devel mailing list