[Ffmpeg-devel] [PATCH] DV Tune Up

[Baptiste Coudurier]

Hi

Brian Brice wrote:
> Hello.
> 
> I have a patch by a coworker of mine that tunes up some issues with DV
> encoding and outputting.  These issues came up when trying to send DV
> data to a DV camera.  The major issue is regarding audio not being able
> to play while the DV data was being sent.  Other issues are for writing
> "correct" info in certain packs according to standards.  Thanks!
> 
> 
> ------------------------------------------------------------------------
> 
> --- libavcodec/dv.c.orig	2006-11-01 12:21:43.000000000 -0600
> +++ libavcodec/dv.c	2006-11-14 16:17:10.156250000 -0600
> @@ -1096,7 +1096,8 @@
>       *   2. It is not at all clear what STYPE is used for 4:2:0 PAL
>       *      compression scheme (if any).
>       */
> -    int apt = (c->sys->pix_fmt == PIX_FMT_YUV420P ? 0 : 1);
> +    int apt = (c->sys->pix_fmt == PIX_FMT_YUV420P || c->sys->pix_fmt == PIX_FMT_YUV411P) ? 0 : 1;

IIRC, dv ntsc 411p in ffmpeg is coded according to SMPTE 314M and
therefore requires apt to be 1.

Only DV 420p (DVCAM) is following IEC specs.

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312