[Ffmpeg-devel] [PATCH] allow full FLAC metadata in the extradata

Aurelien Jacobs aurel
Thu Nov 23 23:23:30 CET 2006


On Thu, 23 Nov 2006 20:03:43 +0100
Michael Niedermayer <michaelni at gmx.at> wrote:

> Hi
> 
> On Wed, Nov 22, 2006 at 07:54:55PM +0100, Aurelien Jacobs wrote:
> > Hi,
> > 
> > This patch allows to pass a full FLAC metadata packet in the extradata.
> > That's the way flac is stored in matroska.
> 
> looks ok except
> 
> 
> [...]
> >  
> > +static int metadata_parse(FLACContext *s)
> 
> this one should have a doxygen comment at least explaining what the function
> does and what the return value means

Ah.. Absolutely right !
Commited with a doxygen comment.

Aurel




More information about the ffmpeg-devel mailing list