[Ffmpeg-devel] [FWD] [PATCH] immediate decoding of dvd stills

Nico Sabbi nicola_sabbi
Wed Nov 29 01:01:58 CET 2006


Michael Niedermayer wrote:

> is there a problem with return buf_size; ?

no, but why returning ret < bytes actually consumed? I find 
it misleadig

> if not then if (buf_size == 0 || !memcmp(buf, (char[]){0,0,1,0xB7}, 4))
> can be used and the code is a little simpler (note if buf_size>0) then
> there always need to be at least FF_INPUT_BUFFER_PADDING_SIZE bytes allocated
> so no need to check for >= 4

ok

> 
> except that patch ok if it works
> 
> [...]

uhm, it works only this way. Please, check it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpeg12diff-2.diff
Type: text/x-patch
Size: 1141 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061129/12ff3647/attachment.bin>



More information about the ffmpeg-devel mailing list