[Ffmpeg-devel] [PATCH] move ready_floor1 to vorbis.h , change some sruct internals in vorbis.c

[Michael Niedermayer]

Hi

On Sun, Oct 01, 2006 at 12:18:21PM +0200, Oded Shimon wrote:
> On Sun, Oct 01, 2006 at 12:07:44PM +0200, Michael Niedermayer wrote:
> > Hi
> > 
> > On Sun, Oct 01, 2006 at 11:38:35AM +0200, Oded Shimon wrote:
> > > first step to make functions common between vorbis.c and vorbis_enc.c .
> > > 
> > > OK to commit?
> > > 
> > > BTW, the floor calculation in vorbis.c is inlined (render_line) right in 
> > > the floor decode function, so it would be somewhat harder for me to split 
> > > that out...
> > > 
> > > All of the common functions I am putting in vorbis.h . They are mostly 
> > > small, biggest of them is this one, maybe the codebook len2vlc . So I 
> > > don't think they deserve a seperate file...
> > 
> > i have no objections to putting speed critical functions as static inline
> > in vorbis.h but functions which are used just during init should be shared
> > at both source and object level
> 
> 2 problems - global namespace pollution (ff_nth_root ??), 

i see no problem here


> and, where 
> should i put the code?? in vorbis.c ? vorbis_data.c ? vorbis_common.c ?

not vorbis_data.c, iam fine with the other 2 options
you could also rename vorbis_data.c to vorbis_common.c if you want, its all
pretty much the same

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is