[Ffmpeg-devel] [PATCH] move ready_floor1 to vorbis.h , change some sruct internals in vorbis.c

Oded Shimon ods15
Sun Oct 1 13:12:01 CEST 2006


On Sun, Oct 01, 2006 at 12:48:06PM +0200, Oded Shimon wrote:
> On Sun, Oct 01, 2006 at 12:39:51PM +0200, Michael Niedermayer wrote:
> > Hi
> > 
> > On Sun, Oct 01, 2006 at 12:18:21PM +0200, Oded Shimon wrote:
> > > On Sun, Oct 01, 2006 at 12:07:44PM +0200, Michael Niedermayer wrote:
> > > > Hi
> > > > 
> > > > On Sun, Oct 01, 2006 at 11:38:35AM +0200, Oded Shimon wrote:
> > > > > first step to make functions common between vorbis.c and vorbis_enc.c .
> > > > > 
> > > > > OK to commit?
> > > > > 
> > > > > BTW, the floor calculation in vorbis.c is inlined (render_line) right in 
> > > > > the floor decode function, so it would be somewhat harder for me to split 
> > > > > that out...
> > > > > 
> > > > > All of the common functions I am putting in vorbis.h . They are mostly 
> > > > > small, biggest of them is this one, maybe the codebook len2vlc . So I 
> > > > > don't think they deserve a seperate file...
> > > > 
> > > > i have no objections to putting speed critical functions as static inline
> > > > in vorbis.h but functions which are used just during init should be shared
> > > > at both source and object level
> > > 
> > > 2 problems - global namespace pollution (ff_nth_root ??), 
> > 
> > i see no problem here
> > 
> > 
> > > and, where 
> > > should i put the code?? in vorbis.c ? vorbis_data.c ? vorbis_common.c ?
> > 
> > not vorbis_data.c, iam fine with the other 2 options
> > you could also rename vorbis_data.c to vorbis_common.c if you want, its all
> > pretty much the same
> 
> ok, vorbis.c then. New patch.

Committed.

- ods15




More information about the ffmpeg-devel mailing list