[Ffmpeg-devel] [PATCH] ac3 decoder

Justin Ruggles jruggle
Mon Oct 2 02:35:37 CEST 2006


Michael Niedermayer wrote:
> Hi
> 
> On Sun, Oct 01, 2006 at 06:00:26PM -0400, Justin Ruggles wrote:
> 
>>Justin Ruggles wrote:
>>
>>>Benjamin Larsson wrote:
>>>
>>>
>>>>Agree, I think this is a leftover from the development process.
>>>
>>>
>>>I think I've narrowed the problem down to the recent change to
>>>initializes AVCodecContext with the AVOption defaults.  Prior to that,
>>>avctx->channels was set to zero (by memset).  Now that it is set to 1,
>>>the ac3 parser thinks the user manually set it, so it does not override
>>>it with the value from the ac3 header.
>>>
>>>Given that, I don't know how the parser could determine if the mono
>>>downmix is a user request or just the default...  If there is no way
>>>around this, maybe the parser should be changed to always leave the
>>>number of channels alone and force the user to set it?
>>
>>This patch makes things work as expected.
> 
> 
> wont it break >2 channel ac3 transcoding to 1/2 channels?
> 
> [...]

Hmm. You're right.




More information about the ffmpeg-devel mailing list