[Ffmpeg-devel] [PATCH] Which Vorbis encoder by default

[Michael Niedermayer]

Hi

On Tue, Oct 03, 2006 at 08:20:00PM +0200, Oded Shimon wrote:
> On Tue, Oct 03, 2006 at 03:30:18PM +0200, Diego Biurrun wrote:
> > On Mon, Oct 02, 2006 at 09:46:02PM +0200, Oded Shimon wrote:
> > > On Mon, Oct 02, 2006 at 08:37:14PM +0200, Michael Niedermayer wrote:
> > > > 
> > > > On Mon, Oct 02, 2006 at 07:20:30PM +0200, Diego Biurrun wrote:
> > > > > On Mon, Oct 02, 2006 at 05:13:08PM +0200, Oded Shimon wrote:
> > > > > > On Mon, Oct 02, 2006 at 04:53:23PM +0200, Oded Shimon wrote:
> > > > > > > Right now, the only way to get ffmpeg to use the library vorbis encoder is 
> > > > > > > to manually disable the native one.
> > > > > > > I'm thinking maybe the default vorbis encoder should be the library one, 
> > > > > > > and the way to choose the native one would be with -acodec vorbis_native . 
> > > > > > > You'd still need to use --enable-libogg --enable-vorbis to get the library 
> > > > > > > one, just like before... But if you didn't, there would be no "vorbis" 
> > > > > > > encoder at all, just "vorbis_native".
> > > > > > 
> > > > > > Different patch - there will always be a "vorbis" encoder, which one it is 
> > > > > > depends on if ffmpeg was compiled with --enable-vorbis or not (which is 
> > > > > > now a misleading option name btw, it should be --enable-libvorbis), and 
> > > > > > there will always be a "vorbis_native" encoder. Is this acceptable?
> > > > > 
> > > > > I dislike adding native to the name of our encoder.  I'd say rename the
> > > > > libvorbis one to libvorbis or oggvorbis instead.
> > > > 
> > > > agree
> > > 
> > > Well the intent is to use the libvorbis encoder by default if ffmpeg was 
> > > compiled with it...
> > 
> > That's perfectly OK, but independent of adding native to the name of our
> > encoder .. :)
> 
> So what do you suggest for the case of ffmpeg compiled with libvorbis, yet 
> still wanting to use my encoder?
> The idea is that the codec named "vorbis" depends on if ffmpeg was 
> compiled with libvorbis or not, and some other name, will always point to 
> my encoder.

id suggest that we drop libvorbis support and you hurry a little with
improving quality of your encoder

see google/wikipedia/citeseer/source code of other encoders for 
psychoacoustics for example
and support for both blocksizes is also a must

IMHO the encoder should have some sort of distortion measure
function (in reality that will be just a weighted sum of squares
where the weights for different coefficients come from the psycoacoustic
model)

and then just minimize rate(=number of bits) + distortion * quality(=constant)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is