[Ffmpeg-devel] [BUG] in make uninstall-headers

[Víctor Paesa]

Hi,
>
> Vi?ctor Paesa said:
>> Hi,
>>
>> make uninstall produces this error:
>>
>> make -C libavutil   uninstall-headers
>> make[1]: Entering directory
>> `/home/wzrlpy/src/FFmpeg-20061002-6412/ffmpeg/libavutil'
>> rm -f "/usr/local/include/ffmpeg/avutil.h
>> /usr/local/include/ffmpeg/common.h
>> /usr/local/include/ffmpeg/mathematics.h
>> /usr/local/include/ffmpeg/integer.h /usr/local/include/ffmpeg/rational.h
>> /usr/local/include/ffmpeg/intfloat_readwrite.h
>> /usr/local/include/ffmpeg/md5.h /usr/local/include/ffmpeg/adler32.h
>> /usr/local/include/ffmpeg/log.h /usr/local/include/ffmpeg/fifo.h"
>> rm: cannot remove `/usr/local/include/ffmpeg/avutil.h
>> /usr/local/include/ffmpeg/common.h
>> /usr/local/include/ffmpeg/mathematics.h
>> /usr/local/include/ffmpeg/integer.h /usr/local/include/ffmpeg/rational.h
>> /usr/local/include/ffmpeg/intfloat_readwrite.h
>> /usr/local/include/ffmpeg/md5.h /usr/local/include/ffmpeg/adler32.h
>> /usr/local/include/ffmpeg/log.h /usr/local/include/ffmpeg/fifo.h': File
>> name too long
>>
>> This proposed patch (also attached) should solve it.
>>
>> ===================================================================
>> --- ffmpeg/common.mak   (revision 6412)
>> +++ ffmpeg/common.mak   (working copy)
>> @@ -86,7 +86,7 @@
>>         -rm -f "$(libdir)/$(LIB)"
>>
>>  uninstall-headers:
>> -       rm -f "$(addprefix $(incdir)/,$(HEADERS))"
>> +       rm -f $(addprefix $(incdir)/,$(HEADERS))
>>         rm -f "$(libdir)/pkgconfig/lib$(NAME).pc"
>
> That fix is incorrect, as it leaves the names unquoted.
>

Right, it would fail on paths with spaces inside.

Next attempt:

===================================================================
--- ffmpeg/common.mak   (revision 6547)
+++ ffmpeg/common.mak   (working copy)
@@ -86,7 +86,7 @@
        -rm -f "$(libdir)/$(LIB)"

 uninstall-headers:
-       rm -f "$(addprefix $(incdir)/,$(HEADERS))"
+       rm -f $(addprefix "$(incdir)/",$(HEADERS))
        rm -f "$(libdir)/pkgconfig/lib$(NAME).pc"

 .PHONY: all depend dep clean distclean install* uninstall*

Regards,
V?ctor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.overquoted-uninstall.2.diff
Type: text/x-patch
Size: 431 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061004/02ac822d/attachment.bin>