[Ffmpeg-devel] [PATCH] idct8 in Altivec for H.264 decoding

[Guillaume POIRIER]

Hi,

On 10/9/06, Luca Barbato <lu_zero at gentoo.org> wrote:
> Guillaume POIRIER wrote:
>
> >
> > Well, I'm certainly not pushing to merge _all_ x264 macros, just the
> > ones I'm using in idct8.
>
> =)

Ok, so when shall I move TRANSPOSE8 ?


> > I'm not sure if I understood what you meant regarding "perfmon"... in
> > any case, I want to mention that being able to use the PMCs is a must
> > in FFmpeg, so please don't remove them.
>
> I'd rather make them less invasive, as is takes too much code.

I assume you're not talking about the lines:

#ifndef POWERPC_MODE_64BITS
#define POWERP_PMC_DATATYPE unsigned long
#define POWERPC_GET_PMC1(a) asm volatile("mfspr %0, 937" : "=r" (a))
#define POWERPC_GET_PMC2(a) asm volatile("mfspr %0, 938" : "=r" (a))
#if (POWERPC_NUM_PMC_ENABLED > 2)
[...]

in libavcodec/ppc/dsputil_ppc.h ?

That surely doesn't seem too invasive and too much code.... I imagine
you weren't talking about these lines?


> This day I'll remove the C code duplication.

Fine with me.

Guillaume
-- 
With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has
a lead on USA on selling out individuals right to corporations!
Vive la France!