[Ffmpeg-devel] Shorten audio FourCC

[Baptiste Coudurier]

Hi

Diego Biurrun wrote:
>>>>>>> [...]
>>>>>>>
>>>>>>> RIFF files use 16-bit IDs for audio.  Adding a bogus 32-bit ID there to
>>>>>>> work around design limitations in mplayer is unacceptable IMO.
>>>>>> MPlayer can happily work also with 16-bit identifiers. But FOURCCs are
>>>>>> used by most formats, and look "better" than a random 16-bit IDs.
>>>>> You're missing the point.  The file riff.c contains mappings between ffmpeg
>>>>> CODEC_ID_* values and IDs used in RIFF-type files (AVI and WAV mainly).
>>>>> This
>>>>> should not be abused as a place for mappings between ffmpeg CODEC_ID_* and
>>>>> mplayer internal numbers.  This becomes even more an abuse when the numbers
>>>>> chosen are impossible to use in RIFF files.
>>>> I count 5 32-bit IDs already.
>>> That's 5 errors, and they are no excuse for adding yet another.
>> As it's not going to make fixing the issue significantly harder, I
>> really don't think it's a big deal.
> 
> I've committed shrn as ID and a FIXME comment that outlines the problem.
> Reimar and Roberto are with me on this and Michael as well if I
> understood his mail right.
> 
> Mans, please don't be angry, as soon as we have 16 bit IDs for all
> codecs we shall resolve this issue properly.
> 

I was also against this. I bet this won't be fixed in a short time,
since it is working now.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312