[Ffmpeg-devel] [PATCH] Clean up in libavcodec/Makefile
Fri Oct 13 18:05:10 CEST 2006
On Fri, Oct 13, 2006 at 01:10:39PM +0200, Guillaume POIRIER wrote:
> On 10/13/06, Diego Biurrun <diego at biurrun.de> wrote:
> >On Fri, Oct 13, 2006 at 11:21:27AM +0200, Guillaume Poirier wrote:
> >> Zuxy Meng wrote:
> >> > Since all intrinsics have been removed there's no need to check this
> >> > in the Makefile. Hence the patch.
> >> I'm against removing them. Even though they aren't any currently, some
> >> my come back in the future (be it as an interim solution before
> >> someone re-write them is pure asm).
> >> Maybe a wiser solution would be to comment them out though, if we
> >> don't need them with current codebase.
> >I disagree. With this reasoning we would never remove anything from the
> >codebase leading to ever-growing bloat ..
> After actually _reading_ the patch I now agree with removing the part
> _from the makefile_ (yes, I know I should read more carefully and not
> skim through the mails).
> I thought the patch was to remove the configure check, which I oppose,
> even though I'm well aware that it makes configure check for things
> that don't matter.
> There also, if someone what to remove these checks, I'd prefer if they
> could just be commented out.
> I'm also well aware that if they were removed from configure, they
> could be resurrected anytime thanks to svn history, but I figure it
> would just make the life of someone willing to contribute code with
> intrinsics easier.
I've removed it, the code can easily be resurrected at any time.
More information about the ffmpeg-devel