[Ffmpeg-devel] x264-r592 breaks ffmpeg r6687

[Michael Niedermayer]

Hi

On Sun, Oct 15, 2006 at 12:22:42AM +0200, Luca Barbato wrote:
> sean wrote:
> > Today's x264 svn breaks today's ffmpeg:
> > 
> 
> Patch for it including letting set crf in the correct way hopefully
[...]
> -{"crf", NULL, OFFSET(crf), FF_OPT_TYPE_INT, DEFAULT, INT_MIN, INT_MAX, V|E},
> +{"crf", NULL, OFFSET(crf), FF_OPT_TYPE_FLOAT, DEFAULT, FLT_MIN, FLT_MAX, V|E},

for this AVCodecContext->crf would have to be changed from int to float ...

also IIRC x264 has some generic option handling, we should use that if
possible, the idea would be to first set everything up based on the normal
values in AVCodecContext like we do currently but with x264_param_parse()
this should prevent some compatibility breaks ...
and then pass any -genericopt or -gopt or whatever we call it argument 
to the codec (for x264 it would need to be choped up, maybe with a=b:c=d:...
style?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is