[Ffmpeg-devel] [PATCH] watermark.c improvement when using imagesas input

Mihail Stoyanov screamer
Fri Oct 20 16:22:35 CEST 2006

Quoting development policy doesn't impress me.
Try to convert a video using the original watermark.c and my patched 
watermark.c and you will get the exact (bit-to-bit) result. With one major 
difference - my fix makes work faster.

Applying my patch over the original source code is up to you.
Still if you don't - then it's obvious you don't care about the end user and 
the cpu time wasted by ffmpeg's watermark pointless itterations, just 
because they weren't written cpu-wise by their author.

quoting "Rational Thinking for Newbies":
"8. Respect everyones job - especially when it's free"

----- Original Message ----- 
From: "Michael Niedermayer" <michaelni at gmx.at>
To: "FFmpeg development discussions and patches" <ffmpeg-devel at mplayerhq.hu>
Sent: Friday, October 20, 2006 4:58 PM
Subject: Re: [Ffmpeg-devel] [PATCH] watermark.c improvement when using 
imagesas input

> [cut]
> quoting development policy:
> 6. We refuse source indentation and other cosmetic changes if they are 
> mixed with functional changes, such commits will be rejected and removed. 
> Every developer has his own indentation style, you should not change it. 
> Of course if you (re)write something, you can use your own style, even 
> though we would prefer if the indentation throughout FFmpeg was consistent 
> (Many projects force a given indentation style - we don't.). If you really 
> need to make indentation changes (try to avoid this), separate them 
> strictly from real changes. NOTE: If you had to put if(){ .. } over a 
> large (> 5 lines) chunk of code, then either do NOT change the indentation 
> of the inner part within (don't move it to the right)! or do so in a 
> separate commit
> for the whole policy see http://ffmpeg.mplayerhq.hu/ffmpeg-doc.html
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> In the past you could go to a library and read, borrow or copy any book
> Today you'd get arrested for mere telling someone where the library is
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

More information about the ffmpeg-devel mailing list