[Ffmpeg-devel] imgresample.c possible loop counter error?

Steven Johnson mplayer
Sun Oct 22 23:27:53 CEST 2006


In imgresample.c at around line 686, there is the following code:

    uint8_t *buf1 = NULL, *buf2 = NULL;
    enum PixelFormat current_pix_fmt;
    for (i = 0; i < 3; i++) {
        src_pict.data[i] = src[i];
        src_pict.linesize[i] = srcStride[i];
        dst_pict.data[i] = dst[i];

Shouldn't the loop actually be <= 3, because the array's being 
initialised have 4 entries each, not 3?  Otherwise src_pict.data[3] (and 
the others) is uninitialised.

Or is this for a reason?

Steven J

More information about the ffmpeg-devel mailing list