[Ffmpeg-devel] [PATCH] send RTCP Reciever report

[Michael Niedermayer]

Hi

On Mon, Oct 23, 2006 at 02:11:16PM +0000, thijsvermeir at telenet.be wrote:
> Hello,
> 
> here is a patch against head for sending RTCP receiver reports.
> Some encoders needs this reports to keep alive.
> 
> Gr,

> Index: libavformat/rtp.c
> ===================================================================
> --- libavformat/rtp.c	(revision 6775)
> +++ libavformat/rtp.c	(working copy)
> @@ -199,6 +199,9 @@
>      MpegTSContext *ts; /* only used for MP2T payloads */
>      int read_buf_index;
>      int read_buf_size;
> +    /* used to send back RTCP RR */

not doxygen compatible comment


> +    URLContext *rtp_ctx;
> +    char hostname[16];

why 16? this seems a little too short to me


[...]
> +    rtcp_bytes /= 50; // mmu_man: that's enough for me... VLC sends much less btw !?

where does this come from? it looks copy and pasted but theres no such line
in ffmpeg svn HEAD or my grep is broken


[...]
> +#define USERAGENT "FFMpeg libavformat " LIBAVFORMAT_IDENT

LIBAVFORMAT_IDENT alone should be ok or?


[...]
> @@ -704,6 +706,8 @@
>      pstrcpy(buf, sizeof(buf), cmd);
>      snprintf(buf1, sizeof(buf1), "CSeq: %d\r\n", rt->seq);
>      pstrcat(buf, sizeof(buf), buf1);
> +    snprintf(buf1, sizeof(buf1), "User-Agent: %s\r\n", USERAGENT);
> +    pstrcat(buf, sizeof(buf), buf1);

is this needed? just asking as iam not sure if it belongs in this patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is