[Ffmpeg-devel] [PATCH] inttypes.h/stdint.h abstract is in common.h

[Michael Niedermayer]

Hi

On Tue, Oct 24, 2006 at 06:35:57PM +0200, Diego Biurrun wrote:
> On Tue, Oct 24, 2006 at 06:12:24PM +0200, Michael Niedermayer wrote:
> > 
> > On Tue, Oct 24, 2006 at 05:43:18PM +0200, Steve Lhomme wrote:
> > > Rich Felker wrote:
> > > >On Tue, Oct 24, 2006 at 04:32:36PM +0200, Steve Lhomme wrote:
> > > >>
> > > >>....for platforms with no inttypes.h
> > > >
> > > >This is utter nonsense. If the platform is missing inttypes.h, just
> > > >put your inttypes.h replacement in the current directory when
> > > >compiling.
> > > 
> > > The code that does what you suggest is in common.h
> > > 
> > > #ifndef EMULATE_INTTYPES
> > > #   include <inttypes.h>
> > > #else
> > >     typedef signed char  int8_t;
> > >     typedef signed short int16_t;
> > >     typedef signed int   int32_t;
> > >     typedef unsigned char  uint8_t;
> > >     typedef unsigned short uint16_t;
> > >     typedef unsigned int   uint32_t;
> > >     typedef signed long long   int64_t;
> > >     typedef unsigned long long uint64_t;
> > > #endif /* EMULATE_INTTYPES */
> > > 
> > > Either this remain and my patch is OK. Otherwise that means common.h 
> > > needs to be changed and that file you're talking about needs to be 
> > > created and put in libavutil.
> > 
> > IMHO configure should check if inttypes.h is available, and if not should
> > create/copy one in libavutil
> 
> Why?  What we have in libavutil/common.h now seems to be good enough
> already ...

hmm, ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is