[Ffmpeg-devel] [PATCH] BMP encoder

[Michel Bardiaux]

Diego Biurrun wrote:
> On Mon, Oct 30, 2006 at 05:25:08PM +0100, Michel Bardiaux wrote:
>> Diego Biurrun wrote:
>>> On Mon, Oct 30, 2006 at 04:54:15PM +0100, Michel Bardiaux wrote:
>>>> Diego Biurrun wrote:
>>>>> On Mon, Oct 30, 2006 at 04:05:39PM +0100, Michel Bardiaux wrote:
>>>>>
>>>>>> --- libavcodec/allcodecs.c	(revision 6838)
>>>>>> +++ libavcodec/allcodecs.c	(working copy)
>>>>>> @@ -134,6 +134,7 @@
>>>>>> #ifdef CONFIG_PNG_ENCODER
>>>>>>    register_avcodec(&png_encoder);
>>>>>> #endif //CONFIG_PNG_ENCODER
>>>>>> +    register_avcodec(&bmp_encoder);
>>>>>> #endif
>>>>>> #ifdef CONFIG_PPM_ENCODER
>>>>>>    register_avcodec(&ppm_encoder);
>>>>> This should be surrounded by proper #ifdef.  Also, put this next to the
>>>>> BMP decoder.
>>>> Done.
>>> The lines are still not next to the BMP_DECODER at line 588.
>> That's not in the patch because in svn there is already at line 588:
>>
>> #ifdef CONFIG_BMP_DECODER
>>     register_avcodec(&bmp_decoder);
>> #endif
> 
> Let me try to be more explicit.  Now there is
> 
>   #ifdef CONFIG_BMP_DECODER
>       register_avcodec(&bmp_decoder);
>   #endif
> 
> after your patch there should be
> 
>   #ifdef CONFIG_BMP_DECODER
>       register_avcodec(&bmp_decoder);
>   #endif
>   #ifdef CONFIG_BMP_ENCODER
>       register_avcodec(&bmp_encoder);
>   #endif
> 
> Clear now?

Yes. My code for registering the encoder was in the wrong place.

> 
> Diego


-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/