[Ffmpeg-devel] [PATCH] BMP encoder

Michel Bardiaux mbardiaux
Mon Oct 30 18:50:35 CET 2006

Michael Niedermayer wrote:
> Hi
> to put 8bit a simple uint8_t will do ...
> for 16bit a simple uint16_t with le2me_16() will do as long as its
> aligned and i think it is ...

After checking a 4th time, it appears that we dont have alignment: the 
thing begins with byte/byte/long. So, I cant use the reverse of the 
stuff in bytestream.h since they assume alignment (although that is not 
documented. Naughty naughty...)

> same for 32bit
> if its not aligned then there are ST16() ST32() in dsputil.h, they could
> be moved into a bytesomething.h (in a seperate patch ...)

No other way: I have to make a 'foundation' patch to do that move. To 
bytestream.h OK?

Note that I have some doubts about that code: it seems to assume that IF 
the compiler is not gcc THEN alignment is not an issue for 16 or 32 bits 
store. That is clearly wrong. Is dsputil.h supposed to be included by 
client code? If not, then why the 'else not GNUC clause?

> [...]

Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles

More information about the ffmpeg-devel mailing list