[Ffmpeg-devel] [PATCH] rewrite vhook/drawtext.c

Gustavo Sverzut Barbieri barbieri
Wed Sep 6 16:22:04 CEST 2006


On 9/6/06, Diego Biurrun <diego at biurrun.de> wrote:
> On Wed, Sep 06, 2006 at 10:13:19AM -0300, Gustavo Sverzut Barbieri wrote:
> >
> > --- vhook/Makefile    (revision 6179)
> > +++ vhook/Makefile    (working copy)
> > @@ -35,7 +35,7 @@
> >
> >  %$(SLIBSUF): %.o
> > -     $(CC) $(LDFLAGS) -g -o $@ $(VHOOKSHFLAGS) $<
> > +     $(CC) $(LDFLAGS_$@) $(VHOOKLIBS) $(LDFLAGS) -g -o $@ $(VHOOKSHFLAGS) $<
>
> Why do you add $(VHOOKLIBS) here?

it was a remaining from tests with cygwin patch.

before I sent another patch with just this fix, do you really require
incremental patches? It will take me some time and as I said, it's
better to review the new code instead of changes. But if really
required I can do :-)

Thanks for keeping the high quality! :-)

-- 
Gustavo Sverzut Barbieri
--------------------------------------
Jabber: barbieri at gmail.com
   MSN: barbieri at gmail.com
  ICQ#: 17249123
 Skype: gsbarbieri
Mobile: +55 (81) 9927 0010
 Phone:  +1 (347) 624 6296; 08122692 at sip.stanaphone.com
   GPG: 0xB640E1A2 @ wwwkeys.pgp.net




More information about the ffmpeg-devel mailing list