[Ffmpeg-devel] [PATCH] Better tag support

[Benjamin Larsson]

Hi,

Panagiotis Issaris wrote:

>Hi,
>
>This patch enhances the tag support: More specifically it changes ffplay to 
>show comments and copyright info besides the current track, title, author,
>album, year and genre. Secondly, it makes the AVI demuxer parse the album
>name stores in the IPRD tag by the AVI muxer.
>
> ffplay.c             |    4 ++++
> libavformat/avidec.c |    3 +++
> 2 files changed, 7 insertions(+)
>
>With friendly regards,
>Takis
>  
>
>------------------------------------------------------------------------
>
>diff --git a/ffplay.c b/ffplay.c
>index 77d4aaa..be9972b 100644
>--- a/ffplay.c
>+++ b/ffplay.c
>@@ -1755,6 +1755,10 @@ static void dump_stream_info(const AVFor
>         fprintf(stderr, "Title: %s\n", s->title);
>     if (s->author[0] != '\0')
>         fprintf(stderr, "Author: %s\n", s->author);
>+    if (s->copyright[0] != '\0')
>+        fprintf(stderr, "Copyright: %s\n", s->copyright);
>+    if (s->comment[0] != '\0')
>+        fprintf(stderr, "Comment: %s\n", s->comment);
>     if (s->album[0] != '\0')
>         fprintf(stderr, "Album: %s\n", s->album);
>     if (s->year != 0)
>diff --git a/libavformat/avidec.c b/libavformat/avidec.c
>index 0e03365..bb4714f 100644
>--- a/libavformat/avidec.c
>+++ b/libavformat/avidec.c
>@@ -476,6 +476,9 @@ #endif
>         case MKTAG('I', 'G', 'N', 'R'):
>             avi_read_tag(pb, s->genre, sizeof(s->genre), size);
>             break;
>+        case MKTAG('I', 'P', 'R', 'D'):
>+            avi_read_tag(pb, s->album, sizeof(s->album), size);
>+            break;
>  
>
Can you add this to the muxer also or does it already have that ?

>         default:
>             /* skip tag */
>             size += (size & 1);
>
MvH
Benjamin Larsson

-- 
new tiny signature