[Ffmpeg-devel] [PATCH] pointer targets differ in signedness

[Måns Rullgård]

Luca Barbato said:
> Rich Felker wrote:
>> On Sun, Sep 10, 2006 at 08:49:08PM +0100, M?ns Rullg?rd wrote:
>>> matthieu castet <castet.matthieu at free.fr> writes:
>>>
>>>> M?ns Rullg?rd wrote:
>>>>> Luca Barbato <lu_zero at gentoo.org> writes:
>>>>>
>>>>>> M?ns Rullg?rd wrote:
>>>>>>
>>>>>>> This patch gets rid of many of the "pointer targets differ in
>>>>>>> signedness" warnings generated by gcc4.
>>>>>>>
>>>>>>> Please, can those with knowledge of the files listed below check that
>>>>>>> I didn't do something stupid?  Needless to say, regression tests pass
>>>>>>> with these changes.
>>>>>> since the warn is stupid I expect this.
>>>>>>
>>>>>> did you check that is is ok on different arches? (the ones with signed
>>>>>> or unsigned char as default)
>>>>> I don't know of an arch that has unsigned char as default.
>>>>>
>>>> PPC is one of them : I remember asking me with getopt wasn't returning
>>>> -1...
>>> I don't have a PPC.
>>
>> GCC has a compiler flag to override default signedness for char.
>
> that you shouldn't use globally.
>
> I'd suppress this warning since is meaningless btw...

For char/unsigned char I agree it is mostly pointless.  There are however
a few instances of int16_t/uint16_t mixups that I think should be corrected.

-- 
M?ns Rullg?rd
mru at inprovide.com