[Ffmpeg-devel] [PATCH] fix mpegaudiodec on ARM and benchmark

[Siarhei Siamashka]

On Wednesday 13 September 2006 12:27, Diego Biurrun wrote:

> On Wed, Sep 13, 2006 at 10:52:07AM +0200, Guillaume POIRIER wrote:
> > On 9/12/06, Siarhei Siamashka <siarhei.siamashka at gmail.com> wrote:
> > >Also it is not quite related to ffmpeg, but mplayer can't be
> > >configured to use HAVE_IWMMXT, so it does not use full optimizations
> > >on xscale cpu such as yours, maybe it is a good idea to fix it?
> >
> > Yes, sure. I'm quite confident that all it takes it to add a configure
> > check.
>
> Yes, patch welcome.

In the mean time here is a patch for ffmpeg configure script adding 
armv5te instructions support detection (pretty much a copy-paste from
iwmmxt detection). Also changed mpegaudiodec.c to use this new 
HAVE_ARMV5TE define.

Tested on Nokia 770 after crosscompilation in scratchbox with:
# ./configure --extra-cflags=-mcpu=arm926ej-s --disable-mpegaudio-hp

So theoretically 3 types of ARM machines can supported:
1. armv4 (probably some older StrongARM machines)
2. armv5te (TI OMAP1710 (arm926ej-s core) on Nokia 770)
3. armv5te + iwmmx instructions (Intel XScale on Zaurus)

ARCH_ARMV4L is defined for all arm processors
HAVE_ARMV5TE is defined for armv5 processors with Enhanced DSP Extensions
HAVE_IWMMXT is defined for intel xscale processors with IWMMX instructions

Any comments/objections regarding configuration options or their naming?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: armv5te-configure.diff
Type: text/x-diff
Size: 2845 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060913/3b322279/attachment.diff>