[Ffmpeg-devel] [PATCH] Add kibi, mibi and gibi support

[Michael Niedermayer]

Hi

On Mon, Sep 18, 2006 at 11:13:12AM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> Op zondag 17 september 2006 13:11, schreef Michael Niedermayer:
> >[...]
> > > > The attached patch tries to integrate my patch with your commit 6284. In
> > > > fact, I am ripping most of your code and putting it in the av_strtod()
> > > > function, reusing it for your eval.c code. Regression tests succeed.
> > > > 
> > > > "./ffmpeg -i src.avi -b 1000hi dst.avi" now also works :) 
> > > > (nicely shows 101kb/s)
> > [...]
> > > +    /* if requested, fill in tail with the position after the last parsed
> > > +       character */
> > > +    if (tail)
> > > +        *tail = next;
> > >      return d;
> > 
> > why not put the whole under if(next != name){ ... }
> > instead of the if(next == name) special case?
> Absolutely right, as this would remove the need for the duplicate "if (tail) *tail=next; ...".
> Fixed in the attached patch.

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is