[Ffmpeg-devel] [PATCH] [Visibility] Try 2: libpostproc public functions

[Michael Niedermayer]

Hi

On Tue, Sep 19, 2006 at 04:36:43PM +0200, Diego 'Flameeyes' Petten? wrote:
> Okay this is the second try, with the EXPORTED definition replaced with a 
> per-library EXPORTED_FOO define, that allows export/import of symbols.
> 
> The #if block must be replicated once per library (this means that right now I 
> have four of them locally.. haven't touched libswscale yet), I can avoid 
> duplicating it from a single library, but I need it different on every run to 
> allow use of protected visibility for internal symbols.
> 
> -- 
> Diego "Flameeyes" Petten? - http://farragut.flameeyes.is-a-geek.org/
> Gentoo/Alt lead, Gentoo/FreeBSD, Video, AMD64, Sound, PAM, KDE

> Index: libpostproc/postprocess.h
> ===================================================================
> --- libpostproc/postprocess.h	(revision 6289)
> +++ libpostproc/postprocess.h	(working copy)
> @@ -19,6 +19,18 @@
>  #ifndef NEWPOSTPROCESS_H
>  #define NEWPOSTPROCESS_H
>  
> +#ifndef EXPORTED_POSTPROC
> +# if defined(__GNUC__) && (__GNUC__ >= 4)

maybe this should be a HAVE_VISIBILITY which is checked for in configure

except this ive no objections but id like to wait a few days before
commiting this patch, maybe someone has an idea on how to simplify it ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is