[Ffmpeg-devel] [PATCH] Staticising mpeg12data header

Rich Felker dalias
Thu Sep 21 02:18:22 CEST 2006


On Wed, Sep 20, 2006 at 11:52:31PM +0100, M?ns Rullg?rd wrote:
> Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
> 
> > On Wed, 2006-09-20 at 15:00 -0400, Rich Felker wrote:
> >> For global variables it does matter, however global variables are evil
> >> enough already and _prohibitively_ evil when imported from a shared
> >> library. Doing so results in copy-relocations, which in turn introduce
> >
> > You can have global variables _within_ a shared library, the kind for
> > which visibility "hidden" makes sense. FFmpeg has global tables of
> > constants, which aren't all that evil or problematic.
> 
> Global constants are fine.  Global variables are not.

BTW if gcc had an option like the visibility crap, but which only
affected variables (including constants) and not functions, you could
use it on almost all PIC library code and convert all the GOT variable
references to GOTOFF, _without_ having to individually flag attribute
crap.

Rich

 




More information about the ffmpeg-devel mailing list