[Ffmpeg-devel] [PATCH] drawtext.c: 06 fix skip underscore

[Michael Niedermayer]

Hi

On Sat, Sep 23, 2006 at 01:25:42PM -0300, Gustavo Sverzut Barbieri wrote:
> On 9/10/06, Gustavo Sverzut Barbieri <barbieri at gmail.com> wrote:
> >On 9/10/06, M?ns Rullg?rd <mru at inprovide.com> wrote:
> >> "Gustavo Sverzut Barbieri" <barbieri at gmail.com> writes:
> >>
> >> > On 9/10/06, M?ns Rullg?rd <mru at inprovide.com> wrote:
> >> >> "Gustavo Sverzut Barbieri" <barbieri at gmail.com> writes:
> >> >>
> >> >> > vhook cmdline argument doesn't like nested spaces, so in order to 
> >have
> >> >> > spaces in strings used in command line I have to replace underscore
> >> >> > with spaces, but only when used from command line, so if someone 
> >want
> >> >> > to use underscores, one may use a file.
> >> >>
> >> >> What are "nested spaces"?  Are you sure there's no cleaner solution?
> >> >
> >> > ./ffmpeg -vhook "./vhook/drawtext.so -ttest_abc"
> >> >
> >> > works, while
> >> >
> >> > ./ffmpeg -vhook "./vhook/drawtext.so -t'test abc'"
> >> >
> >> > doesn't.
> >>
> >> If you want to fix this, a better approach would be to implement
> >> support for quotes.  The wordexp() function could come in handy there.
> >
> >Okay, so I'll remove this and later fix vhook.
> >
> >Is this ok now?
> 
> any objections?

i think not ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is