[Ffmpeg-devel] [PATCH] Use ff_eval for AVOption parsing

[Panagiotis Issaris]

Hi,

On za, 2006-09-23 at 13:25 +0200, Panagiotis Issaris wrote:
> > [...]
> > > exact reason for the segfault, but I am sending it anyway as I'm off for
> > > lunch and shopping and hoped for some feedback on this patch.
> > 
> > iam against changes which by some mysterious reason fix a segfault ...
> I understand, and in fact fully agree. Just wanted to show the work in
> progress, as to see if there were other objections against it besides
> the "if nan then return" hunks. No need to debug _another_ 3 hours if
> the patch would be rejected for other reasons anyway :)
> [...]
> The segfault appeared when using "min", "max", "default" not when using
> "normal" expression or simple values. So "-b 100000", "-b 100k", "-b
> 100*10" "-b 100*QP2LAMBDA" all worked, "-b default" caused a segfault.
I've found the bug, which is in current FFmpeg already. Can be triggered
by:
ffmpeg -i src.avi -rc_eq takis dst.avi

I'm sending a separate bugreport and patch.

With friendly regards,
Takis