[Ffmpeg-devel] [RFC] WavPack lossless audio decoder

[Kostya]

On Mon, Sep 25, 2006 at 12:47:33PM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Mon, Sep 25, 2006 at 11:42:58AM +0300, Kostya wrote:
> > Here is $subj for review and comments.
> 
> [...]
> > +    if(ctx->zeroes){
> > +        ctx->zeroes--;
> > +        return 0;
> > +    }else if(!(ctx->median[0] & ~1) && !(ctx->median[3] & ~1) && !ctx->zero && !ctx->one){
> 
> isnt that the same as
> ctx->median[0] < 2U && ctx->median[3] < 2U && !ctx->zero && !ctx->one
> 
Original code contains even such pearls as  a = (~b) & 1  for boolean expressions.

[...]

> 
> excepet these iam fine with the patch
> 

Applied with suggested corrections
> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> In the past you could go to a library and read, borrow or copy any book
> Today you'd get arrested for mere telling someone where the library is
>