[Ffmpeg-devel] [PATCH] Ratecontrol does not check for failure of ff_eval

[Michael Niedermayer]

Hi

On Tue, Sep 26, 2006 at 02:40:40PM +0200, Panagiotis Issaris wrote:
[...]
> How about a file containing defines like these?
> #define AV_ERR_BUFSIZE_TOO_SMALL -256
> #define AV_ERR_DIMENSION_INVALID -257
> ...

no objections


> 
> If so, should we start from a certain number to be able to reuse defines like ENOMEM?

id say yes avoid conflicts with E*


> If so, should we then also define them as positive and return -ENOMEM, like some 
> other projects do?

dunno


[...]
> -        encode_picture(s, s->picture_number);
> +        if (encode_picture(s, s->picture_number) < 0)
> +                return -1;

indention looks odd


>  
>          avctx->real_pict_num  = s->picture_number;
>          avctx->header_bits = s->header_bits;
> @@ -5463,10 +5464,14 @@ static void merge_context_after_encode(M
>      flush_put_bits(&dst->pb);
>  }
>  
> -static void estimate_qp(MpegEncContext *s, int dry_run){
> -    if (!s->fixed_qscale)
> +static int estimate_qp(MpegEncContext *s, int dry_run){
> +    if (!s->fixed_qscale) {
> +        s->current_picture.quality;

hmm "expression;" ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is