[Ffmpeg-devel] [PATCH] Ratecontrol does not check for failure of ff_eval

[Michael Niedermayer]

Hi

On Tue, Sep 26, 2006 at 03:15:48PM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> Op dinsdag 26 september 2006 14:52, schreef Michael Niedermayer:
> > On Tue, Sep 26, 2006 at 02:40:40PM +0200, Panagiotis Issaris wrote:
> > [...]
> > > How about a file containing defines like these?
> > > #define AV_ERR_BUFSIZE_TOO_SMALL -256
> > > #define AV_ERR_DIMENSION_INVALID -257
> > > ...
> > 
> > no objections
> I would say such a file belongs in libavcodec/ as people using libavcodec should
> be able to have this file installed/available. Would libavcodec/errno.h be okay,
> or should we avoid using that name, as it might cause confusion because of the
> other errno.h files?

id say choose a differnt name


> 
> > [...]
> > > -        encode_picture(s, s->picture_number);
> > > +        if (encode_picture(s, s->picture_number) < 0)
> > > +                return -1;
> > 
> > indention looks odd
> 
> >[...]
> > > +static int estimate_qp(MpegEncContext *s, int dry_run){
> > > +    if (!s->fixed_qscale) {
> > > +        s->current_picture.quality;
> > 
> > hmm "expression;" ...
> Ouch. Sorry about those, they were both remains of tracing/debugging code...
> Fixed in the attached patch.
> 
>  ffmpeg.c                 |    4 ++++
>  libavcodec/mpegvideo.c   |   20 +++++++++++++-------
>  libavcodec/ratecontrol.c |    6 ++++++
>  libavcodec/snow.c        |   12 ++++++++++--
>  4 files changed, 33 insertions(+), 9 deletions(-)
> 
> Reran regression tests, and they succeeded.

patch looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is