[Ffmpeg-devel] [PATCH] Use ff_eval for AVOption parsing

[Michael Niedermayer]

Hi

On Tue, Sep 26, 2006 at 06:35:55PM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> Op zondag 24 september 2006 14:53, schreef Michael Niedermayer:
> > [...]
> > maybe something like
> > 
> > ff_eval2(..., char **error);
> > #if LIBAVCODEC_VERSION < ...
> > attribute_deprecated ff_eval(eq, ...){
> >     char *error=NULL;
> >     double ret=ff_eval2(eq, ..., &error);
> >     if(error) av_log(..., error, eq);
> >     return ret;
> > }
> > #endif
> 
> Something like the attached patch? Followed by a patch using ff_eval2()
> ofcourse...
> 
>  eval.c |   56 +++++++++++++++++++++++++++++++++++---------------------
>  1 file changed, 35 insertions(+), 21 deletions(-)
> 
> Regression tests succeeded.

isnt it simpler to put error in the struct instead of passing it as arg
into every functon?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is