[Ffmpeg-devel] [PATCH] lpcm 20 and 24 bit support in MPEG PS

[Baptiste Coudurier]

Hi

Reimar D?ffinger wrote:
> Hello,
> On Fri, Sep 29, 2006 at 12:59:04PM +0200, Baptiste Coudurier wrote:
>> This patch add support for 20bit and 24bit lpcm in MPEG PS. There are 4
>> cases, I dunno if factorizing code is worth, It did not look cleaner,
>> I'm not sure though.
> 
> I find it rather hackish to have the LPCM->PCM conversion in the demuxer
> instead as a decoder as MPlayer does, especially for the 20 bit case...
> 
> Greetings,
> Reimar D?ffinger

Demuxer is not doing any conversion, it just depack samples correctly.
That is a demuxer issue, not a codec one, if demuxer do not depack it
you cannot stream copy, and there is no reason to put the code in
libavcodec.

It looks like PCM_S24DAUD case, which has nothing to do in pcm.c, since
it is 20 bit lpcm.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312