[Ffmpeg-devel] [PATCH] lpcm 20 and 24 bit support in MPEG PS

[Reimar Döffinger]

Hello,
On Fri, Sep 29, 2006 at 06:00:04PM +0200, Baptiste Coudurier wrote:
> Demuxer is not doing any conversion, it just depack samples correctly.

With that argument there is no reason why we should have both big and
little endian audio formats either.

> That is a demuxer issue, not a codec one, if demuxer do not depack it
> you cannot stream copy,

Ok, but why is that so? Does the muxer do packing as well? I also wasn't
aware that stream copy does not work with MPlayer for these files.

> and there is no reason to put the code in
> libavcodec.

Well, except that there is lots of similar code there. And that like
this you will be doing 20 bit lpcm -> 24 bit PCM -> 16 bit PCM during
playback which is a waste of CPU time (and not even such a small one if
it was 6 channel 192KHz, 24 bit audio)...

> It looks like PCM_S24DAUD case, which has nothing to do in pcm.c, since
> it is 20 bit lpcm.

Nobody objected to me placing it there...

Greetings,
Reimar D?ffinger