[Ffmpeg-devel] [PATCH] vorbis.h -> vorbis_data.c

Balatoni Denes dbalatoni
Sat Sep 30 18:57:14 CEST 2006


Hi!

szombat 30 szeptember 2006 17.31-kor Oded Shimon ezeket a bolcs gondolatokat 
fogalmazta meg:
> 2 problems I had with the structs being there.
> 1. since vorbis_enc also includes this header, the struct names might mix
> up together
> 2. for the typedefs you have to include bitstream.h and dsputil.h , which
> can bring confusion with bitstram.h weirdness :/
>
> Is it really how it's normally done in ffmpeg? I see in most files the
> context is defined in the C file together... It's how it is in my vorbis
> encoder too.

Ok, you are right. Feel free to move those to vorbis.c than.

> - ods15

bye
Denes

-- 
---
What kills me, doesn't make me stronger.




More information about the ffmpeg-devel mailing list