[Ffmpeg-devel] BlackFin lowlevel pixel operations PATCH

Marc Hoffman mmh
Sun Apr 1 18:07:51 CEST 2007


Diego Biurrun writes:
 > On Sun, Apr 01, 2007 at 07:34:04AM -0400, Marc Hoffman wrote:
 > Content-Description: message body text
 > > Marc Hoffman writes:
 > >  > 
 > >  > Diego Biurrun writes:
 > >  >  > On Fri, Mar 30, 2007 at 07:32:14AM -0400, Marc Hoffman wrote:
 > >  >  > > 
 > >  >  > > --- bfin/dsputil_bfin.c	(revision 8517)
 > >  >  > > +++ bfin/dsputil_bfin.c	(working copy)
 > >  >  > > @@ -18,38 +21,296 @@
 > >  >  > >  
 > >  >  > > +static void bfin_idct_add (uint8_t *dest, int line_size, DCTELEM *block)
 > >  >  > > +{
 > >  >  > > +  ff_bfin_idct (block);
 > >  >  > > +  ff_bfin_add_pixels_clamped (block, dest, line_size);
 > >  >  > > +}
 > >  >  > 
 > >  >  > Here and everywhere else: FFmpeg coding style mandates 4 space
 > >  >  > indentation.
 > >  >  > 
 > >  > 
 > >  > No problem, is that for every indentation level or just the first level?
 > >  > 
 > > dsputils indented.
 > 
 > Please use four spaces everywhere.
 > 
 > Some spelling/grammar nitpicks below.
 > 
 > > --- bfin/fdct_bfin.S	(revision 0)
 > > +++ bfin/fdct_bfin.S	(revision 0)
 > 
 > Umm, I didn't look through this in detail, but this description appears
 > to be a (near) duplicate of the one in bfin/fdct_bfin.S.  That's not
 > good.


Yeah its about time to clean up the commentary in those codes. Thanks
for taking so much time to read that and try to make heads or tails of
the text.  I'm going to spend sometime on this then ship it back to you.

Marc





More information about the ffmpeg-devel mailing list