[Ffmpeg-devel] [PATCH] THP PCM decoder (GSoC Qualification)

[Baptiste Coudurier]

Hi

Marco Gerards wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
>> [...]
>>
>>> Index: libavcodec/adpcm.c
>>> ===================================================================
>>> --- libavcodec/adpcm.c	(revision 8597)
>>> +++ libavcodec/adpcm.c	(working copy)
>>> @@ -442,6 +442,8 @@
>>>      switch(avctx->codec->id) {
>>>      case CODEC_ID_ADPCM_IMA_QT: /* XXX: can't test until we get .mov writer */
>>>          break;
>>> +    case CODEC_ID_ADPCM_THP:
>>> +        break;
>>>      case CODEC_ID_ADPCM_IMA_WAV:
>>>          n = avctx->frame_size / 8;
>> what is this good for?
> 
> I thought Baptiste meant I had to do this to skip the encoding.  I
> assume it is wrong, so I will remove it.

Well IMA_QT returns -1 in encode_init mentioning encoding is not supported,
THP should do the same. Comment from michael is right, and IMA_QT case
in encode_frame should be removed also.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312