[Ffmpeg-devel] Re: Bethsoft VID demuxer and decoder

[Diego Biurrun]

On Tue, Apr 03, 2007 at 12:43:13AM -0700, Nicholas T wrote:
> 
> >please keep things in alphabetical order which where before your change
> 
> sorry, I fixed it in the other makefile as well.

But you haven't put everything in alphabetical order as it should be..

> --- libavcodec/bethsoftvideo.c	(revision 0)
> +++ libavcodec/bethsoftvideo.c	(revision 0)
> @@ -0,0 +1,180 @@
> +
> +/**
> + * WORK IN PROGRESS (2007-03-17)

This is not really necessary, it will not be applied as long as it is a
work in progress.

> +    BethsoftvidContext * vid = avctx->priv_data;
> +    // formats in libavutil/avutil.h
> +    // pal8 has some information which tells this that the palette is
> +    // vid->frame.data[1], and an image would be in vid->frame.data[0]
> +    // note: pal most probably stands for palette, not PAL (vs NTSC)

Is that a question?  What exactly is unclear?  Yes, PAL8 is an 8 bit
palette.

Also, I think /* */ is preferred for multiline comments.

> +                if(block_type == VIDEO_FULL_FRAME_BLOCK) { memset(&line_start[xoffset], buf[0], avctx->width - xoffset); }

Try to keep lines below 80 characters where possible.

> --- libavcodec/avcodec.h	(revision 8603)
> +++ libavcodec/avcodec.h	(working copy)
> @@ -158,6 +158,7 @@
>      CODEC_ID_FFH264,
>      CODEC_ID_DXA,
>      CODEC_ID_DNXHD,
> +    CODEC_ID_BETHSOFTVID,
>      CODEC_ID_THP,

See the comment at the top of this enum.

> @@ -2363,6 +2364,7 @@
>  extern AVCodec xl_decoder;
>  extern AVCodec zlib_decoder;
>  extern AVCodec zmbv_decoder;
> +extern AVCodec bethsoftvid_decoder;

alphabetical order please

> --- libavformat/allformats.h	(revision 8603)
> +++ libavformat/allformats.h	(working copy)
> @@ -168,6 +168,7 @@
>  extern AVInputFormat yuv4mpegpipe_demuxer;
>  extern AVInputFormat tiertexseq_demuxer;
>  extern AVInputFormat x11_grab_device_demuxer;
> +extern AVInputFormat bethsoftvid_demuxer;
>  extern AVInputFormat thp_demuxer;

Ugh, this isn't sorted to begin with, but it should be.  I'll see to
it...

Diego