[Ffmpeg-devel] [PATCH] THP PCM decoder (GSoC Qualification)

[Marco Gerards]

Michael Niedermayer <michaelni at gmx.at> writes:

Hi,

> Hi
>
> On Mon, Apr 02, 2007 at 10:42:41PM +0400, Anonymous Anonym wrote:
>> Marco Gerards wrote:
>> > Hi,
>> > 
>> > Last week I sent in a patch demuxer for THP files, which was applied
>> > yesterday.  Here is a patch to extend it with a PCM decoder, as
>> > promised.  I have tested it with the files Mike uploaded.
>> 
>> i don't know why, but when i applied your patch i don't get clear sound, it hearable, but so dirty with noise so i couldn't hear music in AfterCredits.thp, and with losegame.thp it isn't so good, i get hearable with noise only high parts of sound(as i seem).
>
> better or worse than your thp decoder? or are they both outputing the same
> noise? maybe because the description of the adpcm format isnt completely
> correct?

Perhaps.  There is a player with sound support, the specification is
based on this work or written by the author.  Could someone have a
look at this player to see if it plays back the sound without noise?
I do not have a windows system here and the player seems windows
only...

> it seems it was a very bad idea to allow 2 students to work on the same
> qualification task as both see the code of the other which leads to 
> 2 problems

Because of this I am not looking at Kislyakov Maxim's code.

> * it causes some problem to figure out who qualified and who not
> * students can get pissed on each other ...
>
> so IMHO next year we should require unique qualification tasks for each
> student

As I understood it, it was already the case.  We were asked to put out
name on the wiki, there is a notice just above the list of
qualification tasks.

--
Marco