[Ffmpeg-devel] [PATCH] THP PCM decoder (GSoC Qualification)

Rich Felker dalias
Thu Apr 5 17:36:45 CEST 2007


On Thu, Apr 05, 2007 at 09:29:03AM +0200, Reimar Doeffinger wrote:
> Hello,
> On Thu, Apr 05, 2007 at 12:26:44AM +0200, Michael Niedermayer wrote:
> > > +        long table[16][2];
> > 
> > why not int? the values stored in it seem to be limited to 16bit ...
> 
> long is useless anyway, since AFAIK we assume int to be 32 bit anyway.
> long only has the advantage that it is faster when used as array index
> on 64 bit systems, which is not relevant here.

Int is required to be at least 32 bit on POSIX. It seems we (and
almost all sane projects) make assumptions that at least some minimal
sane subset of POSIX is available. It would be nice to document that
somehow, maybe even give it a name (the subset that's common even to
DOS, Windows, etc.).

Rich




More information about the ffmpeg-devel mailing list