[Ffmpeg-devel] [PATCH] fix error croping

[Michael Niedermayer]

Hi

On Fri, Apr 06, 2007 at 10:15:14AM +0200, Luca Abeni wrote:
> Hi Michael,
> 
> On Thu, 2007-04-05 at 20:28 +0200, Michael Niedermayer wrote:
> 
> [...]
> > > > OK, I add a field for bytes_per_pixel to fix the issue. Please review the
> > > > updated patch again. 
> > > [...]
> > > 
> > > I think the patch now looks much better. But since it adds a field to
> > > the PixFmtInfo structure I think someone else will have to approve it (I
> > > do not feel comfortable with the fields is such structure).
> > 
> > cant the value of the new field be calculated from the existing ones
> > ans so the new field be avoided?
> This is what I was hoping too...
> But I did not mentioned this possibility because I do not really
> understand how to compute the value based on existing fields, since some
> of them confuse me very much. For example, what is "nb_channels" -
> number of channels (including alpha)? For planar formats, it is the
> number of planes, but for packed formats... Why is "nb_channels = 1" for
> PIX_FMT_YUYV422, and "nb_channels = 3" for PIX_FMT_RGB24?

dont ask me, id also say it should be 3 for PIX_FMT_YUYV422


> Also, what's the meaning of *_chroma_shift for packed formats? 

the same as for planar at least it should be


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070406/f799d10a/attachment.pgp>