[Ffmpeg-devel] THP decoder

[Michael Niedermayer]

Hi

On Sat, Apr 07, 2007 at 12:08:20AM +0400, Kislyakov Maxim wrote:
> Hi,
> I tried to make everything according your wishes :)
> This is another new version of the patch.
> 

[...]
> +#include "avformat.h"
> +#include "allformats.h"
> +
> +typedef struct ThpDemuxerContext  {
> +    int maxAudioSamples;              /* != 0 if sound is stored in file */

this comment is not doxygen compatible


[...]
> +static int thp_probe(AVProbeData *p)
> +{
> +    if (p->buf_size < 4)
> +        return 0;
> +    if ((AV_RL32(&p->buf[0]))== MKTAG('T', 'H', 'P', '\0'))

&[0] and () is superfluous


[...]
> +    if ((version != 0x100) && (version != 0x110))

superfluous ()


[...]
> +    thpDemux->fps = av_int2flt(get_be32(pb));
> +    av_set_pts_info(st, 64, 1, thpDemux->fps);

this is wrong av_set_pts_info() does not accept float fps


[...]
> +        } 

trailing whitespace


[...]
> +        m = (buf_size - 80) >> st;
> +        int cnt = 7;

breaks gcc 2.95

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070406/d0f8d346/attachment.pgp>